Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget adds to_html method #94

Merged
merged 3 commits into from
May 29, 2024
Merged

Widget adds to_html method #94

merged 3 commits into from
May 29, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented May 29, 2024

For the moment, it's not possible to render the widget on the docs page directly. This PR adds a to_html method so that we can export the workgraph to an HTML file and then load the HTML file into jupyter-notebook; in this case, the GUI will rendered on the docs page.

We convert the react code to vanilla js so that we can merge all codes into one HTML file.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (df22cf7) to head (8b62b14).

Current head 8b62b14 differs from pull request most recent head 826d3b2

Please upload reports for the commit 826d3b2 to get more accurate results.

Files Patch % Lines
aiida_workgraph/widget/src/widget/__init__.py 9.09% 10 Missing ⚠️
aiida_workgraph/node.py 33.33% 2 Missing ⚠️
aiida_workgraph/workgraph.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   74.22%   73.99%   -0.23%     
==========================================
  Files          63       63              
  Lines        3860     3876      +16     
==========================================
+ Hits         2865     2868       +3     
- Misses        995     1008      +13     
Flag Coverage Δ
python-3.11 73.86% <17.64%> (-0.23%) ⬇️
python-3.9 73.99% <17.64%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 changed the title add to_html method Widget adds to_html method May 29, 2024
@superstar54 superstar54 merged commit 493e131 into main May 29, 2024
10 checks passed
@superstar54 superstar54 deleted the workgraph_to_html branch May 29, 2024 21:08
superstar54 added a commit that referenced this pull request May 30, 2024
For the moment, it's not possible to render the widget on the docs page directly. This PR adds a to_html method so that we can export the workgraph to an HTML file and then load the HTML file into jupyter-notebook; in this case, the GUI will rendered on the docs page.

We convert the react code to vanilla js so that we can merge all codes into one HTML file.
superstar54 added a commit that referenced this pull request May 30, 2024
For the moment, it's not possible to render the widget on the docs page directly. This PR adds a to_html method so that we can export the workgraph to an HTML file and then load the HTML file into jupyter-notebook; in this case, the GUI will rendered on the docs page.

We convert the react code to vanilla js so that we can merge all codes into one HTML file.
superstar54 added a commit that referenced this pull request May 30, 2024
For the moment, it's not possible to render the widget on the docs page directly. This PR adds a to_html method so that we can export the workgraph to an HTML file and then load the HTML file into jupyter-notebook; in this case, the GUI will rendered on the docs page.

We convert the react code to vanilla js so that we can merge all codes into one HTML file.
superstar54 added a commit that referenced this pull request May 30, 2024
For the moment, it's not possible to render the widget on the docs page directly. This PR adds a to_html method so that we can export the workgraph to an HTML file and then load the HTML file into jupyter-notebook; in this case, the GUI will rendered on the docs page.

We convert the react code to vanilla js so that we can merge all codes into one HTML file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants