-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add add_node
and add_link
#75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 75.19% 75.25% +0.05%
==========================================
Files 69 69
Lines 4580 4591 +11
==========================================
+ Hits 3444 3455 +11
Misses 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7a78f42
to
23b0122
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update add_node
method to add_task
following new convention.
A bit more context
It is important that these new AiiDA tools keep the end user not only in mind but of utmost importance. Interface like add_task
and add_link
don't add much to the code. However, they can have a serious impact on user experience. add_task()
(one method) vs. tasks.new()
(two methods) is actually a big difference w.r.t UX.
NOTE: Highly opinionated 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
add_node
andadd_link
Note: the original
nodes.new
andlinks.new
is still kept.