Refactor task's data, bumps node-graph to 0.0.19
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change properties is a list in to_dict
1) inputs and outputs to dict 2) keep property inside input 3) use path and name for the node_class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 75.75% 80.39% +4.64%
==========================================
Files 70 66 -4
Lines 4615 4999 +384
==========================================
+ Hits 3496 4019 +523
+ Misses 1119 980 -139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superstar54
force-pushed
the
keep_property_data_in_inputs
branch
from
edd8852 to
4dd8794
Compare
superstar54
changed the title
node-graph to 0.0.19
GeigerJ2
pushed a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
This PR bumps `node-graph` to 0.0.19, so that we don't need to pickle the `node-class`: 1) inputs and outputs to dict 2) keep property inside input 3) use the `module` and `name` for the node_class and executor
GeigerJ2
added a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
This PR bumps `node-graph` to 0.0.19, so that we don't need to pickle the `node-class`: 1) inputs and outputs to dict 2) keep property inside input 3) use the `module` and `name` for the node_class and executor
agoscinski
pushed a commit
that referenced
this pull request
Sep 19, 2024
This PR bumps `node-graph` to 0.0.19, so that we don't need to pickle the `node-class`: 1) inputs and outputs to dict 2) keep property inside input 3) use the `module` and `name` for the node_class and executor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
node-graphto 0.0.19, so that we don't need to pickle thenode-class:moduleandnamefor the node_class and executor