Add executor for WorkGraph task #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
force-pushed
the
fix/285/add_executor_for_workgraph_task
branch
from
c7b3157 to
dd266f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 75.75% 79.73% +3.98%
==========================================
Files 70 65 -5
Lines 4615 4921 +306
==========================================
+ Hits 3496 3924 +428
+ Misses 1119 997 -122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
agoscinski
approved these changes
Sep 6, 2024
GeigerJ2
pushed a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
GeigerJ2
added a commit
to GeigerJ2/aiida-workgraph
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #285 .
The
WorkGraphtask is a built-in task, and theWorkGraphEnginewill be used as theexecutor, therefore, we don't need read it from theexecutor, but, for consistency, we also add the path and name forWorkGraphEngine.