Create a short version of the workgraph data for the connectivity analysis #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
changed the title
This avoid deepcopy the input data of the tasks
superstar54
force-pushed
the
fix/290/avolid_deepcopy_orm_data
branch
from
9df798f to
4aef50d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 75.75% 79.81% +4.06%
==========================================
Files 70 65 -5
Lines 4615 4925 +310
==========================================
+ Hits 3496 3931 +435
+ Misses 1119 994 -125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
agoscinski
approved these changes
Sep 5, 2024
aiida_workgraph/utils/analysis.py
Outdated
| @@ -294,6 +291,9 @@ def check_diff( | |||
| from node_graph.analysis import DifferenceAnalysis | |||
|
|
|||
| wg1 = self.get_wgdata_from_db(restart_process) | |||
| # also make a alias for nodes | |||
| wg1["nodes"] = wg1["tasks"] | |||
| self.wgdata["nodes"] = self.wgdata["tasks"] | |||
There was a problem hiding this comment.
why do you not pop the item here as in the code changes below?
There was a problem hiding this comment.
Thanks! Keeping both tasks and nodes will not raise an error in DifferenceAnalysis. But for consistency, I changed it to be the same as the code below.
|
@superstar54 you are too quick :D was about to report that I had the same error today, and this also fixes it for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analyzing the connectivity of the graph, The actual input data of the tasks is not needed. Therefore, the
ConnectivityAnalysisclass fromnode_graphtries to deepcopy to create a short version. However, it raised an error when deepcoping of the orm.computer, as reported in #290 .In principle, we can fix this inConnectivityAnalysisinnode_graph, but we can also fix it in workgraph. This PR tries to create the short version data before passing toConnectivityAnalysis, and avoids deepcopy the data of the tasks but only picks the info that is needed.This is fixed in the
node-graphpackage, and this PR bumpednode-graphto the latest version.