Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show timeline of called_process #238

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 18, 2024

In the while zone, tasks repeat several times, however, in the timeline it only shows the time for the last iteration of the task. As show below, there is some missing info between add1 and add2.

Screenshot from 2024-08-18 14-12-06

This PR adds the called_process option. Switching to this option, it will show the timeline for all the processes that called by the WorkGraph:
Screenshot from 2024-08-18 14-12-18

@superstar54 superstar54 changed the title show timeline of called_process Show timeline of called_process Aug 18, 2024
@superstar54 superstar54 force-pushed the feature/timeline_called_process branch from 5545a34 to 9200def Compare August 18, 2024 16:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (5937b88) to head (15069d6).
Report is 35 commits behind head on main.

Files Patch % Lines
aiida_workgraph/utils/__init__.py 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   75.75%   79.37%   +3.62%     
==========================================
  Files          70       62       -8     
  Lines        4615     4567      -48     
==========================================
+ Hits         3496     3625     +129     
+ Misses       1119      942     -177     
Flag Coverage Δ
python-3.11 79.24% <77.27%> (+3.57%) ⬆️
python-3.12 79.26% <77.27%> (?)
python-3.9 79.30% <77.27%> (+3.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member Author

Hi @agoscinski , the frontend test caught a bug in this PR. https://github.com/aiidateam/aiida-workgraph/actions/runs/10441999297/job/28914107364

Very helpful!

@superstar54 superstar54 merged commit 116b130 into main Aug 18, 2024
8 checks passed
@superstar54 superstar54 deleted the feature/timeline_called_process branch August 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants