Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonJob use task name as process label #210

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 9, 2024

Provide an input process_label so that the user can set the process label manually. In case of WorkGraph, the process label will be set as: PythonJob<{task['name']}

@superstar54 superstar54 linked an issue Aug 9, 2024 that may be closed by this pull request
@superstar54 superstar54 merged commit 2b568e7 into main Aug 9, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/208/pythonjob_process_label branch August 9, 2024 20:46
@edan-bainglass
Copy link
Member

Very nice! Unfortunately, you missed a closing bracket 😅

inputs = {
        "process_label": f"PythonJob<{task['name']}",    <------------------ missing >
        "function_source_code": orm.Str(function_source_code),
        "function_name": orm.Str(function_name),
        "code": code,
        "function_kwargs": function_kwargs,
        "upload_files": new_upload_files,
        "output_info": orm.List(output_info),
        "metadata": metadata,
        **kwargs,
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PythonJob does not respect the name parameter
2 participants