Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 2: second run-through #57

Merged
merged 5 commits into from
May 10, 2019
Merged

Section 2: second run-through #57

merged 5 commits into from
May 10, 2019

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 9, 2019

Added a new section near the beginning where the user is instructed to
import an export archive, that will be made available at a permanent
public URL later. This will contain the calculations on perovskites
using Quantum ESPRESSO that will be used later in the query builder
section. In this section, this data will also serve to illustrate the
verdi process commands.

I have rewritten quite a bit of text concerning the language around and
the explanation of identifiers. Since identifiers play such a big role
in verdi and this section is about how to use the command line, I
thought it merited some more detail.

Added a new section near the beginning where the user is instructed to
import an export archive, that will be made available at a permanent
public URL later. This will contain the calculations on perovskites
using Quantum ESPRESSO that will be used later in the query builder
section. In this section, this data will also serve to illustrate the
`verdi process` commands.

I have rewritten quite a bit of text concerning the language around and
the explanation of identifiers. Since identifiers play such a big role
in `verdi` and this section is about how to use the command line, I
thought it merited some more detail.
@sphuber sphuber requested a review from ltalirz May 9, 2019 16:32
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @sphuber !
a few more suggestions from my side

@ltalirz ltalirz self-requested a review May 9, 2019 17:20
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the thorough read!

@sphuber
Copy link
Contributor Author

sphuber commented May 9, 2019

thanks a lot for the thorough read!

Right back at ya for the thorough PR. Now go get some sleep! ;)

@sphuber
Copy link
Contributor Author

sphuber commented May 9, 2019

The latex builds are failing because of the unicode symbols in the verdi process list output. These are the typical solutions but they require access to the actual tex document. Not sure how the latex build works and how to tell it to expect utf-8 characters

@ltalirz
Copy link
Member

ltalirz commented May 9, 2019

For a proper explanation of what to do see here.
I just tried switching to xelatex for the build which would have simply ignored the error (and not shown the character in the pdf) but it turns out xelatex isn't available on travis.

The proper way to fix it would be to define a latex representation of the character as
\newunicodechar{⏹}{\ensuremath{\square}}

+ provide latex representation of square character
@ltalirz ltalirz merged commit f0d3403 into tutorial_2019_05 May 10, 2019
@sphuber sphuber deleted the fix_section_2 branch May 10, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants