Fix Except PdosWorkChain when tot_magnetization is used #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
reviewed
Dec 12, 2023
| if 'fermi_energy' in workchain.outputs.output_parameters.dict: | ||
| self.ctx.nscf_fermi = workchain.outputs.output_parameters.dict.fermi_energy | ||
| else: | ||
| self.ctx.nscf_fermi_energy_up = workchain.outputs.output_parameters.dict.fermi_energy_up |
There was a problem hiding this comment.
Thanks @AndresOrtegaGuerrero! Quick question here: do we need to keep nscf_fermi_energy_up and nscf_fermi_energy_down in the context if we determine the Fermi level from the highest value in line 466?
There was a problem hiding this comment.
Yes i will update this !
|
I did another PR #993 so is in my personal account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #988