Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add first version of documentation #88

Merged
merged 3 commits into from
May 7, 2021
Merged

Docs: Add first version of documentation #88

merged 3 commits into from
May 7, 2021

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented May 7, 2021

image

@mbercx mbercx requested a review from sphuber May 7, 2021 01:04
@mbercx mbercx force-pushed the docs/add-documentation branch from 9200bb5 to c566dda Compare May 7, 2021 01:05
@mbercx
Copy link
Member Author

mbercx commented May 7, 2021

Read em and weep (from happiness):

https://filedn.com/lsOzB8TTUIDz2WkFj8o6qhp/aiida-pseudo/index.html#

@sphuber could you give me admin powers so I can set up readthedocs etc? 😁

@sphuber
Copy link
Contributor

sphuber commented May 7, 2021

Read em and weep (from happiness):

https://filedn.com/lsOzB8TTUIDz2WkFj8o6qhp/aiida-pseudo/index.html#

@sphuber could you give me admin powers so I can set up readthedocs etc? grin

Gave admin rights to this repo. Do you need them anywhere else?

sphuber
sphuber requested changes May 7, 2021
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply amazing, thanks a lot @mbercx . I have some minor comments but this is almost good to go

docs/make.bat Outdated Show resolved Hide resolved
docs/source/design.rst Outdated Show resolved Hide resolved
docs/source/design.rst Outdated Show resolved Hide resolved
docs/source/howto.rst Show resolved Hide resolved
docs/source/howto.rst Outdated Show resolved Hide resolved
docs/source/howto.rst Show resolved Hide resolved
docs/source/howto.rst Outdated Show resolved Hide resolved
docs/source/howto.rst Outdated Show resolved Hide resolved
mbercx and others added 2 commits May 7, 2021 12:40
@mbercx @sphuber
Apply suggestions from herr Hubar
d3452e4 
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@mbercx
Polish the docs some more
1d3c9c9
@mbercx mbercx requested a review from sphuber May 7, 2021 11:46
@mbercx
Copy link
Member Author

mbercx commented May 7, 2021

image

@zooks97
Copy link
Contributor

zooks97 commented May 7, 2021

Legendary shitposting, and amazing work @mbercx !

@sphuber
Copy link
Contributor

sphuber commented May 7, 2021

Brace yourself, scope screep is coming

sphuber
sphuber approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impeccable! Tried my hardest to start creeping, but all my efforts were in vain

@sphuber sphuber merged commit 2915812 into master May 7, 2021
@sphuber sphuber deleted the docs/add-documentation branch May 7, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
priority/nice to have topic/docs type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbercx @sphuber @zooks97