Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecommendedCutoffMixin: improve error messages #86

Merged
merged 2 commits into from
May 6, 2021

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented May 6, 2021

Fixes #84
Fixes #85

Improve the error message in two cases:

  • When deleting the final stringency with the delete_cutoffs method.
  • An element requested with the get_recommended_cutoffs method does
    not have a pseudo in the pseudo family.

Improve the error message in two cases:

* When deleting the final stringency with the `delete_cutoffs` method.
* An element requested with the `get_recommended_cutoffs` method does
not have a pseudo in the pseudo family.
@mbercx mbercx requested a review from sphuber May 6, 2021 09:21
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbercx , would just add the new exception to docstring but that is a minor thing

aiida_pseudo/groups/mixins/cutoffs.py Show resolved Hide resolved
@mbercx mbercx requested a review from sphuber May 6, 2021 18:00
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nais!

@sphuber sphuber merged commit bc7e5ea into aiidateam:master May 6, 2021
@mbercx mbercx deleted the fix/84/improve-stingency-error branch May 6, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants