Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: remove temporary upper limit for sqlalchemy #73

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 13, 2021

This reverts 383ab247c40ada60c22ce3673cbbc3efccd21f98. The upper limit
is no longer necessary as the incompatibility of sqlalchemy-utils with
sqlalchemy==1.4 has been solved downstream.

@sphuber
Copy link
Contributor Author

sphuber commented Apr 13, 2021

This is still failing because the limit in aiida-core has not been released yet. We have two options here:

  1. Once aiida-core==1.6.2 is released with the upped requirement of sqlalchemy-utils, we depend on that version of aiida-core and we remove the dependency limit on sqlalchemy here or
  2. We simply remove the sqlalchemy limit here now and add a minimum requirement on sqlalchemy-utils.

Writing it out like this, it seems clear that 2) is the much favored option as we can keep supporting more versions of aiida-core.

EDIT: never mind, aiida-core adds the dependency sqlalchemy-utils~=0.34.2 which is incompatible with what we would like to have sqlalchemy-utils

@sphuber sphuber force-pushed the fix/remove-dependency-pin branch from c32030b to 078e9d9 Compare April 13, 2021 07:12
This reverts `383ab247c40ada60c22ce3673cbbc3efccd21f98`. The upper limit
is no longer necessary as the incompatibility of `sqlalchemy-utils` with
`sqlalchemy==1.4` has been solved downstream.
@sphuber sphuber force-pushed the fix/remove-dependency-pin branch from 078e9d9 to 60c4113 Compare August 13, 2021 08:04
@sphuber
Copy link
Contributor Author

sphuber commented Aug 13, 2021

Just released aiida-core==1.5.3 which fixes the compatibility issues with sqlalchemy and psycopg2-binary, so this can now be merged.

@sphuber sphuber merged commit 7d6d5b8 into master Aug 13, 2021
@sphuber sphuber deleted the fix/remove-dependency-pin branch August 13, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant