PseudoPotentialData: add the get_or_create classmethod
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classmethod has the exact same signature as the constructor but instead of constructing a new instance straightaway, it will first check if the database already contains a node with the exact same class (so no subclassing is used in the query) and with an md5 checksum that matches that of the bytes of the stream. If an existing node is matched, that is returned, otherwise a new instance is constructed and returned unstored.
sphuber
force-pushed
the
feature/032/pseudo-potential-get-or-create
branch
from
806bd18 to
4d8ef71
Compare
zooks97
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
The classmethod has the exact same signature as the constructor but
instead of constructing a new instance straightaway, it will first check
if the database already contains a node with the exact same class (so no
subclassing is used in the query) and with an md5 checksum that matches
that of the bytes of the stream.
If an existing node is matched, that is returned, otherwise a new
instance is constructed and returned unstored.