RecommendedCutoffMixin: Remove workaround for stringency units
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround was added in `v0.6` for families with recommended cutoffs that were installed with `v0.5` since that older version didn't explicitly store the units of the stringencies in the extras which the new API assumed would always be there. The workaround would account for the lack of this extra and would automatically introduce it (in a sense migrating the old family to be compatible with the new API) the first time it would be requested. Almost two years has passed since the release of `v0.6` which should have been plenty for existing families to have been migrated through this workaround and so it can now be removed.
mbercx
approved these changes
Jan 24, 2023
sphuber
force-pushed
the
fix/076/recommended-cutoff-mixin-workaround
branch
from
880c300 to
f6749df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
A workaround was added in
v0.6for families with recommended cutoffs that were installed withv0.5since that older version didn't explicitly store the units of the stringencies in the extras which the new API assumed would always be there.The workaround would account for the lack of this extra and would automatically introduce it (in a sense migrating the old family to be compatible with the new API) the first time it would be requested.
Almost two years has passed since the release of
v0.6which should have been plenty for existing families to have been migrated through this workaround and so it can now be removed.