Use typing.NamedTuple for pseudo family configurations
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SsspConfiguration` and `PseudoDojoConfiguration` tuples were defined using `collections.namedtuple`. These are replaced by using `typing.NamedTuple` which not only provides type hints for the members but it allows to define the `__str__` method, which makes it easier to use the configuration in formatted strings.
sphuber
force-pushed
the
fix/use-typed-named-tuple
branch
from
907dc42 to
8fdd7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SsspConfigurationandPseudoDojoConfigurationtuples weredefined using
collections.namedtuple. These are replaced by usingtyping.NamedTuplewhich not only provides type hints for the membersbut it allows to define the
__str__method, which makes it easier touse the configuration in formatted strings.