Replace SSSP link to legacy MC Archive #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/109/sssp-legacy-url
branch
8 times, most recently
from
b45174c to
b1b0fe6
Compare
This will prevent the CI failing when locally things pass because on the remote a newer version of `pylint` installs which may come with new rules.
When the command was passed an URL it writes the retrieved content to a temporary file on the local file system. Since the underlying unarchiving code attempts to determine the format from the filename, it was attempting to name the temporary file based on the the URL. This worked for the old URL, since there (as luck would have it) the URL ended with the filename containing the correct archive format extension. However, this is clearly not always the case and it is in general impossible to deduce the filename from the URL. It might not even contain an actual filename. There is no other solution then have the user specify the archive format with the `-f` option. It is not made required because for the local files it might not be necessary.
sphuber
force-pushed
the
fix/109/sssp-legacy-url
branch
2 times, most recently
from
eea43e0 to
28fe0be
Compare
The `docutils` requirement is necessary to quell the warning message that was being raised causing the docs build to fail.
The `cli.test_install:test_install_family_url` test was using a link to the legacy version of the Materials Cloud Archive which has now been taken offline, causing the test to fail. The link is updated to point to the new server.
sphuber
force-pushed
the
fix/109/sssp-legacy-url
branch
from
28fe0be to
f098739
Compare
|
Alright @mbercx , took three more problems to be solved to solve the original problem, but with this, the CI is running again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
The
cli.test_install:test_install_family_urltest was using a link tothe legacy version of the Materials Cloud Archive which has now been
taken offline, causing the test to fail. The link is updated to point to
the new server.