Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdt-support: fix adding KIND sections for different sites #136

Merged
merged 2 commits into from
Apr 30, 2021
Merged

gdt-support: fix adding KIND sections for different sites #136

merged 2 commits into from
Apr 30, 2021

Conversation

dev-zero
Copy link
Contributor

@dev-zero dev-zero commented Apr 22, 2021 •
edited
Loading

more tests, more checks, more comfort, more common code. But also more statements.

@dev-zero dev-zero marked this pull request as draft April 23, 2021 06:51
@dev-zero dev-zero marked this pull request as ready for review April 23, 2021 08:38
@yakutovicha yakutovicha self-requested a review April 30, 2021 14:16
yakutovicha
yakutovicha approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dev-zero!

@yakutovicha yakutovicha merged commit 2e72709 into aiidateam:develop Apr 30, 2021
@dev-zero dev-zero deleted the bugfix/gdt-different-kinds branch April 30, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-zero @yakutovicha