Fixed a bug in verdi work kill #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was stopping when killing a workchain with at least one calculation that could not be killed. Now those are skipped.
sphuber
reviewed
Dec 8, 2017
| except InvalidOperation as e: | ||
| if isinstance(child, JobCalculation): | ||
| # Cannot kill calculations that are already killed: skip and go to the next step | ||
| pass |
There was a problem hiding this comment.
Shouldn't we reraise the exception if it is not an instance of JobCalculation here? Otherwise the exception is silently swallowed. Not sure if that is the intended behavior
giovannipizzi
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was stopping when killing a workchain with at least one
calculation that could not be killed. Now those are skipped.