-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #883 #889
Merged
szoupanos
merged 6 commits into
release_v0.10.0rc3
from
fix_for_old_wf_in_sqla_issue_883
Nov 7, 2017
Merged
Fix for issue #883 #889
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cf3e97e
Correcting the workflowdata session problem and adding a test that de…
szoupanos 73477ba
More work on the test
szoupanos fddd4a0
Cleaning the test
szoupanos 29fb0e8
Merge branch 'release_v0.10.0rc3' into fix_for_old_wf_in_sqla_issue_883
szoupanos cf5389a
Merge branch 'release_v0.10.0rc3' into fix_for_old_wf_in_sqla_issue_883
szoupanos 6731502
Merge branch 'release_v0.10.0rc3' into fix_for_old_wf_in_sqla_issue_883
giovannipizzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a test without any SQL specific command (in this case
expunge_all
etc), as this is what the user would do (this could be a generic test) that would have triggered the error before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point.
The problem is that I have not managed to find until today (and it has been a while that I investigate this) a way to isolate the problem at that level (which more or less implies to follow the DbNode object generation in @nmounet workflows - that run by a Daemon that I don't control by my debugger).
Maybe an idea is if I can easily advance the steps of the daemon manually to emulate the daemon steps and see if I have the same behaviour. And if it is true to check what happens at every step with the session and the dbnodes. But this will not be a 10-20 mins job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. For now, then, at least add the same identical test (but without any sqla command) as a general test. Then for me we can merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will.
Just keep in mind that it will be a test that doesn't test anything. I.e. that test would not fail even with the problematic code of set_value() that was corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the test but I did not push it yet. Let's have a short chat before I add it to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see. Let's merge this, then.