Add remote listdir #743
Merged
Add remote listdir #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(or attributes) in the main Transport class. Adding two methods to a RemoteData object to list files (with or without additional properties/attributes).
properly. Also extended the previous test for listdir to also check for files and not only for folders.
listdir_withattributes reducing by one the number of commands to run over ssh - now 'isdir' is obtained from the mode string)
Also improving a bit the exception handling to harmonize local and remote transports
|
I think that it would be better to discuss this in person. I had a look at it and, overall, it looks OK (without having the time to run it). However, I don't see (or I missed) where the listdir() and getfile() are tested. I also need more clarifications on how, overall, the remote transport is tested. Moreover, do we test somewhere the correctness of get_mode_string()? Maybe it is too much to test the latter. |
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands 'verdi data remote [ls,cat,show]' and new functionality in the RemoteData python class to support this.
This also required some extension of the transport plugins.