Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #712: verdi profile delete dbport #713

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Fix #712: verdi profile delete dbport #713

merged 1 commit into from
Sep 22, 2017

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Sep 22, 2017

Fixes #712

@ltalirz ltalirz requested a review from DropD September 22, 2017 07:04
@ltalirz
Copy link
Member Author

ltalirz commented Sep 22, 2017

Once could also use just
postgres.set_port(profile.get('AIIDADB_PORT'))
inside the loop but I think it might be better to repeat determine_setup after the port has changed (?)

@DropD DropD merged commit c3f611d into aiidateam:develop Sep 22, 2017
@ltalirz ltalirz deleted the fix_712_verdi_profile_dbport branch October 31, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DropD DropD DropD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltalirz @DropD