Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy on src/aiida/orm/nodes/caching.py #6703

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

danielhollas
Copy link
Collaborator

This file was already type, but we were telling mypy to ignore it. :-(

The one type change in the return type of get_objects_to_hash was missed in #6323

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (2da3f96) to head (8fbc44f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6703   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         563      563           
  Lines       41762    41762           
=======================================
  Hits        32570    32570           
  Misses       9192     9192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@unkcpz unkcpz merged commit 199a027 into aiidateam:main Jan 14, 2025
10 checks passed
@danielhollas danielhollas deleted the caching-typing branch January 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants