Storage: Add extend_json Tag for Enhanced JSON Field Handling in bulk_update Operations
#6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… bulk-update-json
for more information, see https://pre-commit.ci
… bulk-update-json
rabbull
added
the
pr/work-in-progress
|
If some test hang up, it might benefit from #6674. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6587, it was determined that when performing
bulk_updateoperations on JSON fields likeextra, the existing JSON should be extended rather than overwritten. To address this, this PR introduces a new tag,extend_json, that controls howbulk_updatehandles JSON fields. By default,extend_jsonis set toFalse, ensuring backward compatibility. When explicitly enabled,bulk_updatemerges the provided JSON with the existing JSON field, following to the RFC 7386 - JSON Merge Patch standard. This feature supports both SQLite and PostgreSQL backend.Note:
attributesandextraare JSON fields of interest, and few additional JSON fields will be introduced. As a result, automatic detection of JSON fields is not implemented.bulk_updatelogic for the SQLite DOS backend currently resides inPsqlDosBackend. A dirty workaround has to be added inPsqlDosBackendto address the differences between SQLite and PostgreSQL. This is also stated in a comment block in the code.