CI: quick fix on benchmark CI using uv run pytest #6651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6651 +/- ##
==========================================
+ Coverage 77.51% 77.93% +0.43%
==========================================
Files 560 563 +3
Lines 41444 41662 +218
==========================================
+ Hits 32120 32464 +344
+ Misses 9324 9198 -126 ☔ View full report in Codecov by Sentry. |
danielhollas
reviewed
Dec 5, 2024
|
|
||
| - name: Run benchmarks | ||
| run: pytest --db-backend psql --benchmark-only --benchmark-json benchmark.json tests/ | ||
| run: uv run pytest --db-backend psql --benchmark-only --benchmark-json benchmark.json tests/ | ||
|
|
||
| - name: Store benchmark result | ||
| uses: aiidateam/github-action-benchmark@v3 |
There was a problem hiding this comment.
@unkcpz can you open this PR from origin? It looks like the store step is failing, likely due to permission issue.
There was a problem hiding this comment.
Thanks for the fix btw! Definitely forgot a few spots.
|
reopen not from fork, see #6652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark CI only triggered when push to main and it is failed after #6640.
I mimic the change in 32f9229 for the fix, hope I did it right.
I also make the CI can be triggered for pull request when either benchmark config files changed.