List mypy fix

pyproject.toml

@@ -211,7 +211,7 @@ notebook = [
 ]
 pre-commit = [
   'aiida-core[atomic_tools,rest,tests,tui]',
-  'mypy~=1.10.0',
+  'mypy~=1.13.0',
   'packaging~=23.0',
   'pre-commit~=3.5',
   'sqlalchemy[mypy]~=2.0',

src/aiida/common/lang.py

@@ -96,4 +96,4 @@ def __init__(self, getter: Callable[[SelfType], ReturnType]) -> None:
         self.getter = getter
 
     def __get__(self, instance: Any, owner: SelfType) -> ReturnType:
-        return self.getter(owner)
+        return self.getter(owner)  # type: ignore[arg-type]

src/aiida/common/pydantic.py

@@ -41,7 +41,7 @@ class Model(BaseModel):
     field_info = Field(default, **kwargs)
 
     for key, value in (('priority', priority), ('short_name', short_name), ('option_cls', option_cls)):
-        if value is not None:
+        if value is not None and field_info is not None:
             field_info.metadata.append({key: value})
 
     return field_info

src/aiida/engine/processes/calcjobs/calcjob.py

@@ -1062,7 +1062,7 @@ def presubmit(self, folder: Folder) -> CalcInfo:
 
         def encoder(obj):
             if dataclasses.is_dataclass(obj):
-                return dataclasses.asdict(obj)
+                return dataclasses.asdict(obj)  # type: ignore[arg-type]
             raise TypeError(f' {obj!r} is not JSON serializable')
 
         subfolder = folder.get_subfolder('.aiida', create=True)

src/aiida/engine/processes/workchains/restart.py

@@ -29,7 +29,7 @@
 
 
 def validate_handler_overrides(
-    process_class: 'BaseRestartWorkChain', handler_overrides: Optional[orm.Dict], ctx: 'PortNamespace'
+    process_class: type['BaseRestartWorkChain'], handler_overrides: Optional[orm.Dict], ctx: 'PortNamespace'
 ) -> Optional[str]:
     """Validator for the ``handler_overrides`` input port of the ``BaseRestartWorkChain``.
 

src/aiida/manage/manager.py

@@ -430,7 +430,7 @@ def create_runner(self, with_persistence: bool = True, **kwargs: Any) -> 'Runner
         if with_persistence and 'persister' not in settings:
             settings['persister'] = self.get_persister()
 
-        return runners.Runner(**settings)
+        return runners.Runner(**settings)  # type: ignore[arg-type]
 
     def create_daemon_runner(self, loop: Optional['asyncio.AbstractEventLoop'] = None) -> 'Runner':
         """Create and return a new daemon runner.

src/aiida/orm/nodes/data/array/projection.py

@@ -278,7 +278,7 @@ def array_list_checker(array_list, array_name, orb_length):
                 raise exceptions.ValidationError('Tags must set a list of strings')
             self.base.attributes.set('tags', tags)
 
-    def set_orbitals(self, **kwargs):
+    def set_orbitals(self, **kwargs):  # type: ignore[override]
         """This method is inherited from OrbitalData, but is blocked here.
         If used will raise a NotImplementedError
         """

src/aiida/orm/nodes/data/list.py

@@ -9,6 +9,7 @@
 """`Data` sub class to represent a list."""
 
 from collections.abc import MutableSequence
+from typing import Any
 
 from .base import to_aiida_type
 from .data import Data
@@ -81,15 +82,15 @@ def remove(self, value):
             self.set_list(data)
         return item
 
-    def pop(self, **kwargs):
+    def pop(self, index: int = -1) -> Any:
         """Remove and return item at index (default last)."""
         data = self.get_list()
-        item = data.pop(**kwargs)
+        item = data.pop(index)
         if not self._using_list_reference():
             self.set_list(data)
         return item
 
-    def index(self, value):
+    def index(self, value: Any, start: int = 0, stop: int = 0) -> int:
         """Return first index of value.."""
         return self.get_list().index(value)
 

src/aiida/orm/nodes/data/singlefile.py

@@ -71,9 +71,7 @@ def open(self, path: FilePath, mode: t.Literal['rb']) -> t.Iterator[t.BinaryIO]:
 
     @t.overload
     @contextlib.contextmanager
-    def open(  # type: ignore[overload-overlap]
-        self, path: None = None, mode: t.Literal['r'] = ...
-    ) -> t.Iterator[t.TextIO]: ...
+    def open(self, path: None = None, mode: t.Literal['r'] = ...) -> t.Iterator[t.TextIO]: ...
 
     @t.overload
     @contextlib.contextmanager

src/aiida/plugins/utils.py

@@ -38,7 +38,7 @@ def __init__(self):
     def logger(self) -> Logger:
         return self._logger
 
-    def get_version_info(self, plugin: str | type) -> dict[t.Any, dict[t.Any, t.Any]]:
+    def get_version_info(self, plugin: str | t.Any) -> dict[t.Any, dict[t.Any, t.Any]]:
         """Get the version information for a given plugin.
 
         .. note::

src/aiida/tools/pytest_fixtures/daemon.py

@@ -116,7 +116,7 @@ def test(submit_and_await):
     from aiida.engine import ProcessState
 
     def factory(
-        submittable: 'Process' | 'ProcessBuilder' | 'ProcessNode',
+        submittable: type[Process] | 'ProcessBuilder' | 'ProcessNode' | t.Any,
         state: ProcessState = ProcessState.FINISHED,
         timeout: int = 20,
         **kwargs,

tests/cmdline/groups/test_dynamic.py

@@ -17,7 +17,7 @@ class Model(BaseModel):
         union_type: t.Union[int, float] = Field(title='Union type')
         without_default: str = Field(title='Without default')
         with_default: str = Field(title='With default', default='default')
-        with_default_factory: str = Field(title='With default factory', default_factory=lambda: True)
+        with_default_factory: str = Field(title='With default factory', default_factory=lambda: True)  # type: ignore[assignment]
 
 
 def test_list_options(entry_points):