Transport & Engine: factor out getcwd() & chdir() for compatibility with upcoming async transport
#6593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khsrali
changed the title
Trasnport & `Engine': Transport & Engine: factor out getcwd() & chdir() for compatibility with upcoming async transport
khsrali
force-pushed
the
factor_out_cwd
branch
from
110ebe9 to
7402c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport.getcwd()&Transport.chdir()methods used to making life easier by allowing basically allTransportmethods to function with relative paths.However, for upcoming async changes, this was problematic, as several calculations ended up writing and fetching from wrong directories.
This PR, gets ride of the habit of setting working directory for an entire instance of
Transportclass in engine.Only because in
aiida-coreseveral calculations use a same instance of theTransport, (to avoid opening many channels, etc.)