Engine: Catch NotImplementedErrorin get_process_state_change_timestamp

[sphuber]

The get_process_state_change_timestamp utility calls the method get_global_variable on the storage backend to get the timestamp of the latest process state change, which is typically stored in the db_dbsetting table. However, not all storage plugins implement, most notably the core.sqlite_zip plugin. Since this is read-only, the settings table is never used and requesting the timestamp of the last process state change does not make sense.

Since this utility is used in verdi process list, the command would error since the NotImplementedError was not caught. This is now the case and verdi process list will show "never" as the last state change.

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (ef60b66) to head (7966187).
Report is 115 commits behind head on main.

Files with missing lines	Patch %	Lines
src/aiida/engine/utils.py	83.34%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6489      +/-   ##
==========================================
+ Coverage   77.51%   77.76%   +0.26%     
==========================================
  Files         560      561       +1     
  Lines       41444    41800     +356     
==========================================
+ Hits        32120    32503     +383     
+ Misses       9324     9297      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[khsrali]

does the same ? :)

Suggested change

	try:
	timestamp = backend.get_global_variable(key)
	except NotImplementedError:
	pass
	else:
	if timestamp is not None:
	timestamps.append(datetime.fromisoformat(str(timestamp)))
	except KeyError:
	continue
	timestamp = backend.get_global_variable(key)
	if timestamp is not None:
	timestamps.append(datetime.fromisoformat(str(timestamp)))
	except (KeyError, NotImplementedError) as exc:
	continue

[sphuber]

Technically yes, however, it is often better to wrap try/except statements around specific lines. This makes it clearer which statements could potentially throw which exception.

[khsrali]

makes sense ✅