CLI: Allow higher than index 10 for verdi presto
#6477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
==========================================
+ Coverage 77.51% 77.75% +0.25%
==========================================
Files 560 561 +1
Lines 41444 41771 +327
==========================================
+ Hits 32120 32476 +356
+ Misses 9324 9295 -29 ☔ View full report in Codecov by Sentry. |
sphuber
requested changes
Jun 18, 2024
mbercx
force-pushed
the
fix/presto-overuse
branch
from
53e8439 to
fc39480
Compare
When the user is using `verdi presto` to create more than 11 profiles, the command will fail because `presto-10` already exists. This is due to the fact that the `get_default_presto_profile_name()` function sorts the existing indices as strings, which means `10` will precede `9` and hence the "last index" would be `9`, making the new index `10`, which already exists. Here we fix this issue by casting the extracted existing indices as integers, so the sorting works as intended.
mbercx
force-pushed
the
fix/presto-overuse
branch
from
fc39480 to
756aba4
Compare
sphuber
approved these changes
Jun 19, 2024
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
…team#6477) When the user is using `verdi presto` to create more than 11 profiles, the command will fail because `presto-10` already exists. This is due to the fact that the `get_default_presto_profile_name()` function sorts the existing indices as strings, which means `10` will precede `9` and hence the "last index" would be `9`, making the new index `10`, which already exists. Here we fix this issue by casting the extracted existing indices as integers, so the sorting works as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6476
When the user is using
verdi prestoto create more than 11 profiles, the command will fåail becausepresto-10already exists. This is due to the fact that theget_default_presto_profile_name()function sorts the existing indices as strings, which means10will precede9and hence the "last index" would be9, making the new index10, which already exists.Here we fix this issue by casting the extracted existing indices as integers, so the sorting works as intended.