🐛 RabbitmqBroker: catch ConnectionError for __str__
#6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
==========================================
+ Coverage 77.51% 77.75% +0.25%
==========================================
Files 560 561 +1
Lines 41444 41771 +327
==========================================
+ Hits 32120 32476 +356
+ Misses 9324 9295 -29 ☔ View full report in Codecov by Sentry. |
sphuber
requested changes
Jun 12, 2024
The current implementation of the `RabbitmqBroker.__str__()` method always prints both the version and the URL of the RabbitMQ server. However, the `get_rabbitmq_version()` method fails with a `ConnectionError` in case the RabbitMQ broker is not able to connect to the server. This issue would bubble up into the `verdi status` command, since this prints the string representation of the `RabbitmqBroker` in the message that reports the connection failure. At this point the `ConnectionError` is no longer caught, and hence the user is exposed to the full traceback. Here we adapt the `RabbitmqBroker.__str__()` method to catch the `ConnectionError` and only return the URL in this case.
|
@sphuber this one is ready for a second round of review! |
sphuber
approved these changes
Jun 18, 2024
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
…6473) The current implementation of the `RabbitmqBroker.__str__()` method always prints both the version and the URL of the RabbitMQ server. However, the `get_rabbitmq_version()` method fails with a `ConnectionError` in case the RabbitMQ broker is not able to connect to the server. This issue would bubble up into the `verdi status` command, since this prints the string representation of the `RabbitmqBroker` in the message that reports the connection failure. At this point the `ConnectionError` is no longer caught, and hence the user is exposed to the full traceback. Here we adapt the `RabbitmqBroker.__str__()` method to catch the `ConnectionError` and return the URL with the message that the connection failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
RabbitmqBroker.__str__()method always prints both the version and the URL of the RabbitMQ server. However, theget_rabbitmq_version()method fails with aConnectionErrorin case the RabbitMQ broker is not able to connect to the server.This issue would bubble up into the
verdi statuscommand, since this prints the string representation of theRabbitmqBrokerin the message that reports the connection failure. At this point theConnectionErroris no longer caught, and hence the user is exposed to the full traceback.Here we adapt the
RabbitmqBroker.__str__()method to catch theConnectionErrorand only return the URL in this case.