-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add Dependabot config for maintaining GH actions #6467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6467 +/- ##
==========================================
+ Coverage 77.51% 77.73% +0.23%
==========================================
Files 560 561 +1
Lines 41444 41724 +280
==========================================
+ Hits 32120 32432 +312
+ Misses 9324 9292 -32 ☔ View full report in Codecov by Sentry. |
version: 2 | ||
updates: | ||
# Maintain dependencies for GitHub Actions | ||
- package-ecosystem: github-actions | ||
directory: / | ||
schedule: | ||
interval: monthly | ||
groups: | ||
gha-dependencies: | ||
patterns: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this not trigger if there are no actual updates? I can't be arsed having to deal with automated PRs that don't actually do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No superfluous PRs, guaranteed, I promise, really!
(I've had this config on a couple repos for a while and no problems).
Note also that in this config, if there are multiple different actions that need update, only one PR is created that combines them all. So you'll need to do at most one click per month. 😛
.github/workflows/release.yml
Outdated
services: | ||
postgres: | ||
image: postgres:10 | ||
env: | ||
POSTGRES_DB: test_aiida | ||
POSTGRES_PASSWORD: '' | ||
POSTGRES_HOST_AUTH_METHOD: trust | ||
options: >- | ||
--health-cmd pg_isready | ||
--health-interval 10s | ||
--health-timeout 5s | ||
--health-retries 5 | ||
ports: | ||
- 5432:5432 | ||
rabbitmq: | ||
image: rabbitmq:3.8.14-management | ||
ports: | ||
- 5672:5672 | ||
- 15672:15672 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last PR related to CI (promise!), I saved the perhaps controversial change for last. :-)
Not sure which part of the PR you thought was controversial, I am betting the auto-requirements update, but I think sneaking this change in might be a better candidate. I would be hesitant to change the release workflow since we only just started using the presto suite. I would wait until we have more confidence in its reliability and utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, fair enough, I've reverted the change.
(and yes, it was the dependabot config :-) )
This reverts commit c846c6c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @danielhollas now lay off the CI-candy for a while and take a well-deserved break ;)
Last PR related to CI (promise!), I saved the perhaps controversial change for last. :-)
Added a dependabot config for maintaining GH actions (NOT Python dependencies). It updates monthly, and should be even less frequent since we typically don't pin to the exact versions of the Actions, and major version updates are infrequent.
Also tried to simplify a bit the release workflow by utilizing the newly added
pytest -m presto
tests.