Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Dependabot config for maintaining GH actions #6467

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jun 7, 2024

Last PR related to CI (promise!), I saved the perhaps controversial change for last. :-)

Added a dependabot config for maintaining GH actions (NOT Python dependencies). It updates monthly, and should be even less frequent since we typically don't pin to the exact versions of the Actions, and major version updates are infrequent.

Also tried to simplify a bit the release workflow by utilizing the newly added pytest -m presto tests.

@danielhollas danielhollas requested a review from sphuber June 7, 2024 00:00
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (ef60b66) to head (84ec7f9).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6467      +/-   ##
==========================================
+ Coverage   77.51%   77.73%   +0.23%     
==========================================
  Files         560      561       +1     
  Lines       41444    41724     +280     
==========================================
+ Hits        32120    32432     +312     
+ Misses       9324     9292      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +1 to +11
version: 2
updates:
# Maintain dependencies for GitHub Actions
- package-ecosystem: github-actions
directory: /
schedule:
interval: monthly
groups:
gha-dependencies:
patterns:
- '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not trigger if there are no actual updates? I can't be arsed having to deal with automated PRs that don't actually do anything.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No superfluous PRs, guaranteed, I promise, really!
(I've had this config on a couple repos for a while and no problems).

Note also that in this config, if there are multiple different actions that need update, only one PR is created that combines them all. So you'll need to do at most one click per month. 😛

Comment on lines 57 to 76
services:
postgres:
image: postgres:10
env:
POSTGRES_DB: test_aiida
POSTGRES_PASSWORD: ''
POSTGRES_HOST_AUTH_METHOD: trust
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
- 5432:5432
rabbitmq:
image: rabbitmq:3.8.14-management
ports:
- 5672:5672
- 15672:15672

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last PR related to CI (promise!), I saved the perhaps controversial change for last. :-)

Not sure which part of the PR you thought was controversial, I am betting the auto-requirements update, but I think sneaking this change in might be a better candidate. I would be hesitant to change the release workflow since we only just started using the presto suite. I would wait until we have more confidence in its reliability and utility

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, fair enough, I've reverted the change.
(and yes, it was the dependabot config :-) )

@sphuber sphuber self-requested a review June 7, 2024 07:49
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @danielhollas now lay off the CI-candy for a while and take a well-deserved break ;)

@sphuber sphuber merged commit 0812f4b into aiidateam:main Jun 7, 2024
11 checks passed
@danielhollas danielhollas deleted the dependabot-config branch June 7, 2024 09:08
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
)

* Add dependabot config for maintaining GH actions
* Enable `FORCE_COLOR` environment variable
* Update `uv` installer
* Remove code coverage in `presto` test suite
* Do not install from `requirements.txt` for `verdi`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants