Config: Revert checking of CWD for config directory location #6349
Conversation
sphuber
added
the
priority/critical-blocking
There was a problem hiding this comment.
Thanks @sphuber! I see the definition of an AiiDA instance is still kept to be the .aiida folder, but that's fine. I'll address that concept extensively in an AEP as soon as I find the time (hopefully by early next week). So this is good to go for me.
Since I was the main person arguing for the revert, let me also link to my motivation here: #6315 (comment)
What part of the code/docs are you referring to here? I didn't literally revert the linked commit since the related code was refactored slightly after that and I wanted to keep some of those refactorings that didn't change any of the original behavior. So I think the original behavior and language is restored, but I might have missed something during the manual revert. |
|
The first sentences here, that define an AiiDA instance: Compare this to the current documentation: In fact, now that I read it in more detail, the description of how to (currently) isolate AiiDA instances is also missing, so perhaps we should do a proper revert of the docs as well indeed. |
Sure fine, I reverted part of the docs, removing the CWD from the table, but forgot that I had significantly rewritten it. |
In 1059b5f the logic to determine the location of the configuration directory was modified to also check the hierarchy of the current working directory for an existing directory. After discussion, it seems that this change is more impactful than anticipated and needs to be discussed in more depth before being released. Therefore the change is reverted for now.
sphuber
force-pushed
the
fix/revert-cwd-config-directory-discovery
branch
from
3e93be3 to
38cd87b
Compare
|
Thanks @sphuber, everything looks in place again now! Good to go for me 🚀 |
In 1059b5f the logic to determine the location of the configuration directory was modified to also check the hierarchy of the current working directory for an existing directory. After discussion, it seems that this change is more impactful than anticipated and needs to be discussed in more depth before being released. Therefore the change is reverted for now.