Caching: Rename get_hash to compute_hash
#6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_hash` method was actually recomputing the hash and not just returning the hash stored in the extras that was computed when the node got stored. The `get_hash` and `_get_hash` methods are renamed to `compute_hash` and `_compute_hash`, respectively. This allows `get_hash` to be reimplemented to simply return the hash stored in the extras. Although technically speaking this is changing the implementation of public facing API, if users even use `get_hash()` it will have been to retrieve the hash for an already stored node, which is therefore equal to just returning the pre-computed hash stored in the extras. So effectively this should not be a breaking change.
danielhollas
approved these changes
Apr 15, 2024
Attributes that can be changed after a node is stored have to be part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_hashmethod was actually recomputing the hash and not just returning the hash stored in the extras that was computed when the node got stored. Theget_hashand_get_hashmethods are renamed tocompute_hashand_compute_hash, respectively. This allowsget_hashto be reimplemented to simply return the hash stored in the extras.Although technically speaking this is changing the implementation of public facing API, if users even use
get_hash()it will have been to retrieve the hash for an already stored node, which is therefore equal to just returning the pre-computed hash stored in the extras. So effectively this should not be a breaking change.