Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.12 tox environment #6291

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add python 3.12 tox environment #6291

merged 1 commit into from
Feb 20, 2024

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Feb 20, 2024 •
edited
Loading

#6161 added support for python 3.12 but did not add a py312 tox environment. This PR remedies that.

sphuber
sphuber requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @edan-bainglass , just one type I think

pyproject.toml Outdated Show resolved Hide resolved
unkcpz
unkcpz reviewed Feb 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@sphuber sphuber merged commit 6b0d439 into aiidateam:main Feb 20, 2024
37 checks passed
@edan-bainglass edan-bainglass deleted the tox-py312 branch February 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz left review comments

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edan-bainglass @sphuber @unkcpz