Tests: Remove deprecated aiida/manage/tests/main module and move system tests
#6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aiidateam/plugin-developers is anyone still relying on the old |
|
in all plugins I maintain we use |
sphuber
force-pushed
the
fix/move-system-tests
branch
2 times, most recently
from
c576396 to
ac983f2
Compare
This module had been deprecated and replaced a long time ago in favor of `pytest` based fixtures that provide a complete testing environment with test profiles being created on-the-fly.
The `.github/system_tests/test_ipython_magics.py` file provided tests for the ipython magics, however, these can simply be run in the main test suite invoked directly through `pytest`.
The `.github/system_tests/pytest/test_memory_leaks.py` file provided tests to ensure memory is not being leaked when running processes. These tests do not require being executed in standalone `pytest` invocation but can be included in the main unit test suite. Historically, the separation was required when the main unit test suite was not fully using `pytest` yet but used a framework based on `unittest`. With this migration, the last test in the `.github/workflows/tests.sh` script has been moved and now it merely calls the main test suite. The CI workflows that called it, now simply directly invoke the command to run the main test suite and the `tests.sh` script is deleted.
sphuber
force-pushed
the
fix/move-system-tests
branch
from
ef510ef to
786d610
Compare
After the previous commit, for some unknown reason, `pylint` started throwing `no-member` and `no-name-in-module` warnings for import lines that import a class directly from `aiida.orm`. The imports actually work just fine and `pylint` didn't use to complain. The changes of the previous commit seem completely unrelated, so for now the warnings are ignored. Soon `pylint` will anyway be replaced by `ruff`.
sphuber
force-pushed
the
fix/move-system-tests
branch
from
786d610 to
d08aed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.