Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker stack build CI action enabled for any changes #6131

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Docker stack build CI action enabled for any changes #6131

merged 1 commit into from
Sep 22, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Sep 21, 2023

The docker build CI was only activated when .docker or .github/workflows/docker*.yaml are changed. It prevent the build check from changes in src code which may potentially break the docker stack build. For example when CLI interface for quicksetup is changed or the interface for computer/code setup is changed, since the docker stack builds relies on running these commands inside.

@unkcpz unkcpz changed the title docker build CI turned on for any changes Docker stack build CI turned on for any changes Sep 21, 2023
@unkcpz unkcpz changed the title Docker stack build CI turned on for any changes Docker stack build CI action enabled for any changes Sep 21, 2023
@unkcpz unkcpz force-pushed the docker/build-test-from-pr branch from a9b839a to cacf4bc Compare September 21, 2023 19:51
@unkcpz
Copy link
Member Author

unkcpz commented Sep 21, 2023

"Build, test and push Docker Images" is triggered and will be fixed by #6129

@unkcpz unkcpz force-pushed the docker/build-test-from-pr branch from cacf4bc to f408f14 Compare September 21, 2023 21:51
@unkcpz unkcpz requested a review from sphuber September 21, 2023 21:56
@sphuber
Copy link
Contributor

sphuber commented Sep 22, 2023 •
edited
Loading

Is there a way to exclude paths? It would be good if we can exclude the tests and docs folders. Or maybe we can simply add the aiida/* path to the current ones. Would be wasteful to run these workflows if we are just fixing tests or updating docs.

And maybe we can just be even more specific and add aiida/cmdline/* and aiida/orm/* as those are the most likely to be changed and potentially break things?

@unkcpz
Docker stack build CI action enabled for any changes
9a9a1d2 
The docker build CI was only activated when `.docker` or
`.github/workflows/docker*.yaml` are changed. It prevent the build
check from changes in src code which may potentially break the
docker stack build. For example when CLI interface for `quicksetup`
is changed or the interface for `computer/code` setup is
changed, since the docker stack builds relies on running these commands inside.

We use paths-ignore to ignore the trigger of docker stack build when changes
are from `docs/` or `tests/`.
@unkcpz unkcpz force-pushed the docker/build-test-from-pr branch from f408f14 to 9a9a1d2 Compare September 22, 2023 07:49
@unkcpz
Copy link
Member Author

unkcpz commented Sep 22, 2023

And maybe we can just be even more specific and add aiida/cmdline/* and aiida/orm/* as those are the most likely to be changed and potentially break things?

Yes, there is paths-ignore syntax that can be used for it (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-and-excluding-paths), I exclude "docs/" and "tests/".

sphuber
sphuber approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz

@sphuber sphuber merged commit 1b5b669 into aiidateam:main Sep 22, 2023
@unkcpz unkcpz deleted the docker/build-test-from-pr branch September 22, 2023 08:31
@unkcpz unkcpz mentioned this pull request Sep 27, 2023
Merged
sphuber pushed a commit that referenced this pull request Nov 14, 2023
@unkcpz @sphuber
Devops: Loosen trigger conditions for Docker build CI workflow (#6131)
441c150 
The docker build workflow was only activated when changes were made to
either the `.docker` directory or `.github/workflows/docker*.yaml` files.
However, changes in the `aiida` package could also break the build and
so could pass by unnoticed.

The trigger conditions are changed to instead trigger always except for
changes to the `tests` and `docs` directories.

Cherry-pick: 1b5b669
sphuber pushed a commit that referenced this pull request Nov 15, 2023
@unkcpz @sphuber
Devops: Loosen trigger conditions for Docker build CI workflow (#6131)
22e8a80 
The docker build workflow was only activated when changes were made to
either the `.docker` directory or `.github/workflows/docker*.yaml` files.
However, changes in the `aiida` package could also break the build and
so could pass by unnoticed.

The trigger conditions are changed to instead trigger always except for
changes to the `tests` and `docs` directories.

Cherry-pick: 1b5b669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unkcpz @sphuber