CalcJob: Add support for nested targets in remote_symlink_list
#5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, nice! I was actually just running into this issue when testing aiidateam/aiida-quantumespresso#918. Let me give this a spin in the field. |
|
Any updates on this @mbercx ? |
|
Haven't managed to test it yet. Can I rebase the branch? My storage in the project I can test this in has already been migrated to |
It is now possible to specify a target in the `remote_symlink_list` that contains nested directories that do not necessarily exist. The `upload_calculation` will automatically create them before creating the symlink.
sphuber
force-pushed
the
feature/4726/nested-remote-symlinks
branch
from
b05d89b to
bc391fb
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4726
It is now possible to specify a target in the
remote_symlink_listthat contains nested directories that do not necessarily exist. Theupload_calculationwill automatically create them before creating the symlink.