Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Bump graphviz version to 0.19 #5965

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Apr 13, 2023

In the commit 80045ae a feature was added that allows the user to specify the output name of the generated graph with verdi node graph generate. This filename is passed to the outfile input argument of the graphviz.render() method, but this was only added in v0.19 of graphviz, see:

https://graphviz.readthedocs.io/en/latest/changelog.html#version-0-19

Here we bump the graphviz version to 0.19.

In the commit 80045ae a feature was
added that allows the user to specify the output name of the generated
graph with `verdi node graph generate`. This filename is passed to the
`outfile` input argument of the `graphviz.render()` method, but this was
only added in v0.19 of `graphviz`, see:

https://graphviz.readthedocs.io/en/latest/changelog.html#version-0-19

Here we bump the `graphviz` version to `0.19`.
@mbercx mbercx requested a review from sphuber April 13, 2023 16:21
@sphuber
Copy link
Contributor

sphuber commented Apr 13, 2023

I see, the tests passed for the PR you referenced because in the CI run, the latest version 0.19 was actually installed. Didn't think that this was a recent feature for graphviz. Thanks for the PR!

@sphuber sphuber merged commit 9a81d10 into aiidateam:main Apr 13, 2023
@mbercx mbercx deleted the update-graphviz-version branch April 14, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants