Generate content for verdi code show command from input CLI fields
#5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConradJohnston
changed the title
verdi something list commands dynamicallyverdi something show commands dynamically
ConradJohnston
force-pushed
the
Improve_verdi_something_list_commands
branch
from
4fd5e10 to
6bd795b
Compare
ConradJohnston
changed the title
verdi something show commands dynamicallyverdi code show commands dynamically
ConradJohnston
changed the title
verdi code show commands dynamicallyverdi code show commands from input CLI fields
ConradJohnston
force-pushed
the
Improve_verdi_something_list_commands
branch
from
910258d to
7e8b9b0
Compare
ConradJohnston
changed the title
verdi code show commands from input CLI fieldsverdi code show command from input CLI fields
ConradJohnston
force-pushed
the
Improve_verdi_something_list_commands
branch
2 times, most recently
from
6adfc7f to
eb667ac
Compare
sphuber
requested changes
Mar 6, 2023
sphuber
requested changes
Mar 7, 2023
Some CLI commands like `verdi code show` rely on printing various node attributes 'by hand' and so may miss certain attributes and must be maintained 'by hand' on an ongoing basis. This commit uses `get_cli_options` to populate the output table for the `show` subcommand automatically, so as to ensure completeness of output and to simplify future maintenance.
ConradJohnston
force-pushed
the
Improve_verdi_something_list_commands
branch
from
eb667ac to
d18320a
Compare
|
Thanks a lot @ConradJohnston |
sphuber
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CLI commands like
verdi code showhave relied on printing various node attributes 'by hand' and so may miss certain attributes and must be maintained 'by hand' on an ongoing basis.Here instead, we use
get_cli_optionsto populate the output table for theshowsubcommand automatically, so as to ensure completeness of output and to simplify future maintenance.