-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Workflow: Update sphinx-intl new release & Install Transifex CLI. #5908
CI Workflow: Update sphinx-intl new release & Install Transifex CLI. #5908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @AhmedBasem20, just one minor request. Can you also add a version for the transifex cli as mentioned in https://github.com/transifex/cli#installing-with-a-script-linuxmac?
I think there is some problem on my initial implementation, since I now realize it is not a good practice to push to transifex when new version released. The documentation .pot
files need to updated when there are new changes in /doc
folder in the main branch, which will make the latest
of other language versions of documentation synchronize with the latest official version.
But nothing related to this PR, and I'll leave it to myself in the future.
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
Thanks @unkcpz for reviewing. I added the requested transifex cli version. Your insight on best practices is greatly appreciated. Thanks again for your time and guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AhmedBasem20. I give it a local test, all good!
CLoses #5748
The new sphinx-intl release (2.1.0) is now updated, Also Transfix CLI installation script has been added.