Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Notify that an entry point is required for creating a data plugin #5907

Merged

Conversation

AhmedBasem20
Copy link
Contributor

@AhmedBasem20 AhmedBasem20 commented Feb 26, 2023

Fixes #5456

Walking through the examples here will fail because the data entry point registering step is required but not mentioned.

I added a simple note for registering with an entry point.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmedBasem20 . Small suggestion for the phrasing and a fix for the link syntax, which was incorrect

docs/source/topics/data_types.rst Outdated Show resolved Hide resolved
@AhmedBasem20 AhmedBasem20 force-pushed the docs/5456/require-data-entry-point branch from 635d92f to be9fe3e Compare March 3, 2023 15:54
@AhmedBasem20
Copy link
Contributor Author

Thanks @sphuber for reviewing. The suggested changes are updated.

@sphuber sphuber merged commit bf18a9b into aiidateam:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: examples on creating data plugin fail because they do not include registering with entry point
2 participants