ORM: Return None
in get_function_source_code
instead of excepting
#5730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5726
The
FunctionCalculationMixin
which is used for the nodes of process functions has the functionget_function_source_code
which will raiseFileNotFoundError
if the source code file does not exist in the repository. This will happen typically for functions defined in an interactive shell where theinspect
package cannot determine the source code.The docstring erroneously said that
None
would be returned, but even worse it said that the absolute filepath would be returned, whereas it was supposed to give the source code as a string.The docstring is fixed and the method now returns
None
if the source code file doesn't exist instead of raising.