[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.3.0

[chrisjsewell]

Heya @sphuber I'd rather you didn't keep closing these pre-commit PRs, they are opened for a reason.
If they pass just merge them.

In this case, it appears there is now an intermittent failure of tests/cmdline/commands/test_process.py::test_process_pause across all PRs.
Is this something that was added recently?

[sphuber]

they are opened for a reason.

What is that reason if they literally don't change anything in the pre-commit?

[chrisjsewell]

What is that reason if they literally don't change anything in the pre-commit?

they do, they update versions of the linting tools, which improves the linting of future PRs

[sphuber]

they do, they update versions of the linting tools, which improves the linting of future PRs

And in this case, none of the linting tools were affected, as shown by the changes. The new pre-commit was run, and nothing was changed whatsoever. If the change is a no-op, why keep merging these? As soon as the version upping actually changes the linting, of course I would be for merging them. By this point we would have merged at least 4 of these, and none of them had any affect. Now you can say, what does it hurt by merging them, but I can ask the same question.

In this case, it appears there is now an intermittent failure of tests/cmdline/commands/test_process.py::test_process_pause across all PRs. Is this something that was added recently?

I think so, I will try to have a look today to see if I can fix it.

[chrisjsewell]

The new pre-commit was run, and nothing was changed whatsoever

future PRs

[chrisjsewell]

I think so, I will try to have a look today to see if I can fix it.

cheers 🙏

[sphuber]

@chrisjsewell I found the direct cause (see #5687 ) but not sure how to fix it yet.

[chrisjsewell]

Thanks! Will have a look later

[codecov]

Codecov Report

Base: 79.65% // Head: 79.65% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1f801e3) compared to base (0680209).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5682      +/-   ##
==========================================
+ Coverage   79.65%   79.65%   +0.01%     
==========================================
  Files         490      490              
  Lines       36570    36570              
==========================================
+ Hits        29125    29126       +1     
+ Misses       7445     7444       -1     

Impacted Files	Coverage Δ
aiida/transports/plugins/local.py	81.85% <0.00%> (+0.25%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.