Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: pull tag "latest" from Docker Hub #5671

Merged
merged 1 commit into from
Sep 28, 2022
Merged

DOCS: pull tag "latest" from Docker Hub #5671

merged 1 commit into from
Sep 28, 2022

Conversation

pcolaianni
Copy link
Contributor

Users running command git pull aiidateam/aiida-core:2.0.3.post0 would face the following error:

Error response from daemon: manifest for aiidateam/aiida-core:2.0.4.post0 not found: manifest unknown: manifest unknown

That is because the images pushed to Docker Hub have tags that do not end in .post0.

This change reflects this fact, and instead recommends using tag latest.

As in: docker pull aiidateam/aiida-core:latest

Users running command `git pull aiidateam/aiida-core:2.0.3.post0` would
face the following error:

```
Error response from daemon: manifest for aiidateam/aiida-core:2.0.4.post0 not found: manifest unknown: manifest unknown
```

That is because the images pushed to Docker Hub have tags that do not
end in `.post0`.

This change reflects this fact, and instead recommends using tag
`latest`.

As in: `docker pull aiidateam/aiida-core:latest`
@sphuber sphuber self-requested a review September 28, 2022 07:39
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcolaianni , the .post0 identifier is something we started adding after the release of v2.0 to be able to warn users who are using non-released commits, which should only be done for development. This change makes sense, as the latest docs build should also always correspond to the latest aiida-core release.

@sphuber sphuber merged commit 52a40ff into aiidateam:main Sep 28, 2022
@pcolaianni pcolaianni deleted the docs/pull_latest_from_docker_hub branch September 29, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants