Remove explicit PortableCode check in presubmit #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
requested changes
Sep 26, 2022
Comment on lines
103
to
109
| def presubmit_check(self, folder: Folder): | ||
| """check the validity when calling in presubmit. | ||
|
|
||
| :param folder: a SandboxFolder that can be used to write calculation input files and the scheduling script. | ||
| :raises PluginInternalError: The plugin created a file that is also the executable name!. | ||
| """ | ||
|
|
There was a problem hiding this comment.
If we make it concrete in AbstractCode this is no longer needed
Comment on lines
96
to
101
| def presubmit_check(self, folder: Folder): | ||
| if str(self.filepath_executable) in folder.get_content_list(): | ||
| raise exceptions.PluginInternalError( | ||
| f'The plugin created a file {self.filepath_executable} that is also the executable name!' | ||
| ) | ||
|
|
There was a problem hiding this comment.
Here I would update the docstring of the method from the AbstractCode to say:
:raises PluginInternalError: The ``CalcJob`` plugin created a file that has the same relative filepath as the
executable for this portable code.
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
unkcpz
force-pushed
the
refac/portable-remove-from-presubmit
branch
2 times, most recently
from
49d534f to
a1ef420
Compare
|
Cheers @unkcpz . This is good to go. If you can just fix the docs (correcting the reference to |
unkcpz
force-pushed
the
refac/portable-remove-from-presubmit
branch
from
a1ef420 to
50a087a
Compare
unkcpz
force-pushed
the
refac/portable-remove-from-presubmit
branch
from
50a087a to
ac29e50
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at #5664 (comment), in this PR I try to remove the explicit call of the
PortableCodeinpresubmitby adding apresubmit_checkhelper function to code classes.