PluginVersionProvider: add support for entry point strings
#5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_version_info` method now also supports `plugin` being an entry point string. It should be a full entry point string including the entry point group. The method will attempt to load the plugin before continuing as usual determining the version of the corresponding package.
unkcpz
approved these changes
Sep 26, 2022
| @@ -104,6 +104,7 @@ repos: | |||
| aiida/orm/utils/links.py| | |||
| aiida/plugins/entry_point.py| | |||
| aiida/plugins/factories.py| | |||
| aiida/plugins/utils.py| | |||
There was a problem hiding this comment.
Why? This list of files is to explicitly enable type-checking. Since I fixed the type hinting, I added the file to this list.
There was a problem hiding this comment.
Ah, sorry, I thought this is to exclude the file.
sphuber
deleted the
feature/5661/plugin-version-provider-entry-point-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5661
The
get_version_infomethod now also supportspluginbeing an entry point string. It should be a full entry point string including the entry point group. The method will attempt to load the plugin before continuing as usual determining the version of the corresponding package.