Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: Add a notification for nightly workflow on fail #5605

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jul 25, 2022

When the nightly.yml workflow fails it will now send a notification to
the dev-aiida-core channel on the AiiDA Slack.

The specific logic in the conditional is on purpose:

always() && (steps.install.outcome == 'Failure' || steps.tests.outcome == 'Failure')

The reason is that without the always(), the step will never run if
any of the previous steps fail, defeating the purpose. However, this
is not enough, because with just always() the final status of the
workflow will be that of the notification step and so will always be
successful. This is confusing since a failed build will be marked as
successful.

By adding the clause after && the build will still be marked as failed
even if the final notification step runs fine.

When the `nightly.yml` workflow fails it will now send a notification to
the `dev-aiida-core` channel on the AiiDA Slack.
@sphuber sphuber force-pushed the fix/nightly-notify branch from 8231bc0 to 287aa75 Compare July 25, 2022 09:42
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #5605 (8231bc0) into main (e141f97) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8231bc0 differs from pull request most recent head 287aa75. Consider uploading reports for the commit 287aa75 to get more accurate results

@@            Coverage Diff             @@
##             main    #5605      +/-   ##
==========================================
+ Coverage   79.69%   79.69%   +0.01%     
==========================================
  Files         532      532              
  Lines       37928    37928              
==========================================
+ Hits        30223    30224       +1     
+ Misses       7705     7704       -1     
Impacted Files Coverage Δ
aiida/common/utils.py 77.26% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e141f97...287aa75. Read the comment docs.

@sphuber sphuber merged commit bc73d61 into main Jul 27, 2022
@sphuber sphuber deleted the fix/nightly-notify branch July 27, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants