DevOps: Add a notification for nightly workflow on fail #5605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
nightly.yml
workflow fails it will now send a notification tothe
dev-aiida-core
channel on the AiiDA Slack.The specific logic in the conditional is on purpose:
The reason is that without the
always()
, the step will never run ifany of the previous steps fail, defeating the purpose. However, this
is not enough, because with just
always()
the final status of theworkflow will be that of the notification step and so will always be
successful. This is confusing since a failed build will be marked as
successful.
By adding the clause after
&&
the build will still be marked as failedeven if the final notification step runs fine.