fix: is_valid_cache setter for ProcessNodes
#5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cea5be introduced an `is_valid_cache` property that, in theory, can be used to invalidate specific process node instances as far as the cache is concerned: ``` n=load_node(<PK>) n.base.caching.is_valid_cache = False ``` Unfortunately, the setter did not actually work on any `ProcessNode` because in Python `super()` cannot be used to access setters directly (see e.g. https://stackoverflow.com/a/10810545/1069467).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7cea5be introduced an
is_valid_cachesetter that, in theory, can be used to invalidate specific process
node instances as far as the cache is concerned:
Unfortunately, the setter did not actually work on any
ProcessNodebecause in Python
super()cannot be used to access setters directly(see e.g. https://stackoverflow.com/a/10810545/1069467).
fixes #5582