Engine: fix bug when caching from process with nested outputs #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
approved these changes
May 23, 2022
| _, node_clone = run.get_node(NestedOutputsProcess, a=Int(1)) | ||
|
|
||
| assert node_clone.is_created_from_cache | ||
| assert node_clone.get_cache_source() == node_original.uuid |
There was a problem hiding this comment.
do you maybe want to check here that the structure of the cloned node outputs is as expected?
I guess it's fine, just to be safe
When the execution of a process is being skipped because it has a valid cache source and caching is enabled, the process would except if the process has nested output namespaces. Since the nesting cannot be literally preserved in the database, the nesting is representing by using double underscores between each level of nesting in the link label. The problem occurs when `Process._create_and_setup_db_record` would be called which would create the outputs of the cloned node, however, it would use these "collapsed" link labels containing the double underscores. Passing these to `self.out` would cause the validation to fail because the process port validation expects the actual nesting. The solution is to restore the database nesting representation to the one expected by `Process.out`, which amounts to replacing the namespace separators.
sphuber
force-pushed
the
fix/5536/cache-nested-outputs
branch
from
609c4ec to
b629ef3
Compare
sphuber
added a commit
that referenced
this pull request
Sep 22, 2022
When the execution of a process is being skipped because it has a valid cache source and caching is enabled, the process would except if the process has nested output namespaces. Since the nesting cannot be literally preserved in the database, the nesting is representing by using double underscores between each level of nesting in the link label. The problem occurs when `Process._create_and_setup_db_record` would be called which would create the outputs of the cloned node, however, it would use these "collapsed" link labels containing the double underscores. Passing these to `self.out` would cause the validation to fail because the process port validation expects the actual nesting. The solution is to restore the database nesting representation to the one expected by `Process.out`, which amounts to replacing the namespace separators. Cherry-pick: b936da3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5536
When the execution of a process is being skipped because it has a valid
cache source and caching is enabled, the process would except if the
process has nested output namespaces. Since the nesting cannot be
literally preserved in the database, the nesting is representing by
using double underscores between each level of nesting in the link
label.
The problem occurs when
Process._create_and_setup_db_recordwould becalled which would create the outputs of the cloned node, however, it
would use these "collapsed" link labels containing the double
underscores. Passing these to
self.outwould cause the validation tofail because the process port validation expects the actual nesting.
The solution is to restore the database nesting representation to the
one expected by
Process.out, which amounts to replacing the namespaceseparators.