Start of Node namespace reorganization
#5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5472 +/- ##
===========================================
+ Coverage 79.59% 79.63% +0.04%
===========================================
Files 517 517
Lines 37044 37040 -4
===========================================
+ Hits 29483 29493 +10
+ Misses 7561 7547 -14
Continue to review full report at Codecov.
|
All deprecation warning should now use `warn_deprecation` with the correct version number of when the deprecated resource will be removed, instead of using `warnings.warn` directly.
This is a pre-cursor to moving methods off of the `Node` top level namespace.
sphuber
force-pushed
the
fix/reorganize-node-namespace
branch
2 times, most recently
from
867c9e6 to
f338282
Compare
chrisjsewell
approved these changes
Apr 6, 2022
chrisjsewell
suggested changes
Apr 6, 2022
sphuber
force-pushed
the
fix/reorganize-node-namespace
branch
from
f338282 to
5f98acb
Compare
|
@chrisjsewell yeah of course, forgot that part. Should be good now |
sphuber
changed the title
Node namespace reorganization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following results of discussion #5465