Correct version number for RabbitMQ warning #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, a warning was added when a RabbitMQ installation was used with
a version of 3.8 or higher. This was done because a consumer default
timeout was added to the server configuration that would cause unacked
messages to be requeued after only 15 minutes. However, this change was
only added in 3.9:
rabbitmq/rabbitmq-server@80e3992
and was backported in the v3.8 minor version in v3.8.15. Therefore, we
can relax the condition for the warning to be shown only when the
version is 3.8.15 or higher.
chrisjsewell
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a warning was added when a RabbitMQ installation was used with
a version of 3.8 or higher. This was done because a consumer default
timeout was added to the server configuration that would cause unacked
messages to be requeued after only 15 minutes. However, this change was
only added in 3.9:
and was backported in the v3.8 minor version in v3.8.15. Therefore, we
can relax the condition for the warning to be shown only when the
version is 3.8.15 or higher.